Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

From: Finn Thain
Date: Mon Jun 01 2020 - 19:49:44 EST


On Mon, 1 Jun 2020, Geert Uytterhoeven wrote:

> >
> > Sure, it could be absorbed by both asm/mac_iop.h and
> > drivers/macintosh/adb-iop.c [...]
>
> asm/mac_iop.h doesn't include asm/adb_iop.h (at least not in my tree,
> but perhaps you have plans to change that?), so there's only a single
> user.

What I meant by "both" was that part of asm/adb_iop.h could be absorbed by
drivers/macintosh.adb-iop.c and the rest by asm/mac_iop.h. (And some of it
could be tossed out.) I suspect that much of arch/m68k/include/asm could
get the same treatment. But I doubt that there is any pay off, because the
headers rarely change where they relate to hardware characteristics.