Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

From: Markus Elfring
Date: Tue Jun 02 2020 - 07:11:10 EST


> The original patch was basically fine.

I propose to reconsider the interpretation of the software situation once more.

* Should the allocated clock object be kept usable even after
a successful return from this function?

* How much do âdestructorâ calls matter here for (sub)devices?


> Just add a Fixes tag and resend.

This tag can help also.

Regards,
Markus