Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

From: Mark Brown
Date: Tue Jun 02 2020 - 14:36:48 EST


On Tue, Jun 02, 2020 at 05:05:18PM +0200, Markus Elfring wrote:
> >> I find this commit message improvable also according to Linux software
> >> development documentation.

> > Causing people to send out new versions of things for tweaks to the
> > commit log consumes time for them and everyone they're sending changes to.

> Improving patches (besides source code adjustments) is an usual software
> development activity, isn't it?

Your updates were not improvements. The formatting was worse and to my
native speaker eyes the grammar was worse. With this sort of stylistic
thing it's especially important that any review aligns with the needs
and practices of the subsystem, there is opinion in there and multiple
opinions just makes things harder for submitters.

Attachment: signature.asc
Description: PGP signature