Re: [PATCH v4 3/4] mm/util.c: remove the VM_WARN_ONCE for vm_committed_as underflow check

[Feng Tang]

On Tue, Jun 02, 2020 at 12:02:22AM -0400, Qian Cai wrote:
> 
> 
> > On Jun 1, 2020, at 11:37 PM, Feng Tang <feng.tang@xxxxxxxxx> wrote:
> > 
> > I re-run the same benchmark with v5.7 and 5.7+remove_warning kernels,
> > the overall performance change is trivial (which is expected)
> > 
> >   1330147            +0.1%    1331032        will-it-scale.72.processes
> > 
> > But the perf stats of "self" shows big change for __vm_enough_memory() 
> > 
> >      0.27            -0.3        0.00        pp.self.__vm_enough_memory
> > 
> > I post the full compare result in the end.
> 
> I donât really see what that means exactly, but I suppose the warning is there for so long and no one seems notice much trouble (or benefit) because of it, so I think you will probably need to come up with a proper justification to explain why it is a trouble now, and how your patchset suddenly start to trigger the warning as well as why it is no better way but to suffer this debuggability regression (probably tiny but still).

Thanks for the suggestion, and I updated the commit log.