Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() in gx1fb_map_video_memory()

From: Markus Elfring
Date: Wed Jun 03 2020 - 12:49:26 EST


> Add the missed function call to fix the bug.

â
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -208,29 +208,44 @@ static int gx1fb_map_video_memory(struct fb_info *info, struct pci_dev *dev)
â
> return 0;
> +
> +err:
> + pci_disable_device(dev);
> + return ret;
> }
â

I suggest to use more descriptive labels so that the exception handling
can be improved accordingly.

return 0;
+
+e_nomem:
+ ret = -ENOMEM;
+disable_device:
+ pci_disable_device(dev);
+ return ret;
}


Regards,
Markus