Re: [PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init_entities()

From: Sakari Ailus
Date: Thu Jun 04 2020 - 05:51:53 EST


On Thu, Jun 04, 2020 at 12:33:21PM +0300, Laurent Pinchart wrote:
> Hi Chuhong,
>
> (CC'ing Sakari Ailus)
>
> Thank you for the patch.
>
> On Thu, Jun 04, 2020 at 12:41:22AM +0800, Chuhong Yuan wrote:
> > preview_init_entities() does not call v4l2_ctrl_handler_free() when
> > it fails.
> > Add the missed function to fix it.
> >
> > Fixes: de1135d44f4f ("[media] omap3isp: CCDC, preview engine and resizer]")
>
> There's an extra ']' at the end. Apart from that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Sakari, could you take this patch ?

Done; thank you!

--
Sakari Ailus