Re: linux-next: build failure after merge of the origin tree

From: Jessica Yu
Date: Fri Jun 05 2020 - 05:48:53 EST


+++ Josh Poimboeuf [04/06/20 19:04 -0500]:
On Fri, Jun 05, 2020 at 08:37:15AM +1000, Stephen Rothwell wrote:
Hi all,

After merging the origin tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/module.c: In function 'do_init_module':
kernel/module.c:3593:2: error: implicit declaration of function 'module_enable_ro'; did you mean 'module_enable_x'? [-Werror=implicit-function-declaration]
3593 | module_enable_ro(mod, true);
| ^~~~~~~~~~~~~~~~
| module_enable_x

Caused by commit

e6eff4376e28 ("module: Make module_enable_ro() static again")

This config has neither CONFIG_ARCH_HAS_STRICT_MODULE_RWX or
CONFIG_ARCH_HAS_STRICT_MODULE_RWX set. This failure was hidden in
linux-next due to commit

db991af02f11 ("module: break nested ARCH_HAS_STRICT_MODULE_RWX and STRICT_MODULE_RWX #ifdefs")

from the modules tree. I have cherry-picked that commit for today.

Sorry, I guessed we missed that dependency between the live-patching and
module trees.

Jessica, are you planning on sending a pull request?

Yep, just sent. So hopefully this gets resolved in the next day or two.