Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

From: Markus Elfring
Date: Fri Jun 05 2020 - 06:16:00 EST


>> Do you find a previous update suggestion useful?
>>
>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@xxxxxx/
>> https://lore.kernel.org/patchwork/patch/1151158/
>> https://lkml.org/lkml/2019/11/9/125
â
> It is useful indeed.

Thanks for your positive feedback.


> Although I didn't run cocci script, since it can produce too many false result
> which is hard to filter out.

Would you like to clarify any corresponding software analysis options?


> BTW, I see you haver done the work already, I guess I won't send any patches
> related to 'missing put_device after of_find_device_by_node()'.

You may continue also with contributions in such a direction.
I would like to point out that other developers occasionally got into the mood
to improve implementation details in similar ways already.


> Any idea why these pathes didn't get applied ?

I can make assumptions about the reasons for the possibly questionable handling
of such patches.

Regards,
Markus