Re: [PATCH v2 0/3] Relocate execve() sanity checks

From: Andrew Morton
Date: Fri Jun 05 2020 - 20:40:57 EST


On Fri, 5 Jun 2020 09:00:10 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> While looking at the code paths for the proposed O_MAYEXEC flag, I saw
> some things that looked like they should be fixed up.
>
> exec: Change uselib(2) IS_SREG() failure to EACCES
> This just regularizes the return code on uselib(2).
>
> exec: Move S_ISREG() check earlier
> This moves the S_ISREG() check even earlier than it was already.
>
> exec: Move path_noexec() check earlier
> This adds the path_noexec() check to the same place as the
> S_ISREG() check.

Thanks.

These don't seem super-urgent and they aren't super-reviewed, so I
suggest we hold them off until the next cycle?