Re: [PATCH] kernel: power: swap: mark a function as __init to save some memory

From: Dan Carpenter
Date: Mon Jun 08 2020 - 07:23:08 EST


On Sun, May 31, 2020 at 03:11:27PM -0700, Joe Perches wrote:
> (adding Dan Carpenter)
>
> On Sun, 2020-05-31 at 23:00 +0200, Christophe JAILLET wrote:
> > 'swsusp_header_init()' is only called via 'core_initcall'.
> > It can be marked as __init to save a few bytes of memory.
>
> Hey Dan
>
> smatch has a full function calling tree right?
>
> Can smatch find unmarked functions called only by __init
> functions so those unmarked functions can be appropriately
> marked with __init like the below?
>

It turns out it's complicated to do this in Smatch because Sparse
ignores the section attribute. :/

regards,
dan carpenter