Re: [PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

From: Andy Shevchenko
Date: Mon Jun 08 2020 - 08:08:37 EST


On Mon, Jun 8, 2020 at 3:03 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, Jun 8, 2020 at 1:26 PM Alexander Gordeev <agordeev@xxxxxxxxxxxxx> wrote:

...

> Can't we simple do
>
> int chunk_index = 0;
> ...
> do {
> #if defined(CONFIG_64BIT) && defined(__BIG_ENDIAN)
> end = bitmap_get_x32_reverse(start, end,
> bitmap[chunk_index ^ 1]);
> #else
> end = bitmap_get_x32_reverse(start, end, bitmap[chunk_index]);
> #endif
> ...
> } while (++chunk_index);
>
> ?

And moreover, we simple can replace bitmap by maskp here, and drop it
from definition block.

--
With Best Regards,
Andy Shevchenko