Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()

From: Frank Lee
Date: Mon Jun 08 2020 - 08:56:39 EST


On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> > From: Yangtao Li <tiny.windzz@xxxxxxxxx>
> >
> > Using %px to show the actual address in sunxi_mmc_irq()
> > to help us to debug issue.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> > Signed-off-by: Frank Lee <frank@xxxxxxxxxxxxxxxxx>
>
> I'm fairly sure this hash is on purpose, and both the commit log of the
> %px introduction (ad67b74d2469) and the checkpatch message are pretty
> explicit about it.
>
> What issue were you trying to solve here?

There doesn't seem to be a strong requirement to force this to be printed out,
I just think that ____ptrval____ is very unpleasant.

Or delete %p directly?

Yangtao