Re: [RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link extended state

From: Amit Cohen
Date: Tue Jun 09 2020 - 02:58:33 EST


On 07-Jun-20 21:25, Florian Fainelli wrote:
>
>
> On 6/7/2020 7:59 AM, Amit Cohen wrote:
>> Implement .get_down_ext_state() as part of ethtool_ops.
>> Query link down reason from PDDR register and convert it to ethtool
>> ext_state.
>>
>> In case that more information than common ext_state is provided,
>> fill ext_substate also with the appropriate value.
>>
>> Signed-off-by: Amit Cohen <amitc@xxxxxxxxxxxx>
>> Reviewed-by: Petr Machata <petrm@xxxxxxxxxxxx>
>> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
>
> Is the firmware smart enough to report
> ETHTOOL_EXT_SUBSTATE_LT_KR_FRAME_LOCK_NOT_ACQUIRED only when using a *KR
> link mode for instance, or do you need to sanitize that against the
> supported/advertised mode?
>

This reason can appear with copper cable or backplane. At the moment it is only supported with AN and PD modes (not Force mode).