Re: [RESEND PATCH] sys_personality: Add optional arch hook arch_check_personality

From: kernel test robot
Date: Tue Jun 09 2020 - 03:26:35 EST


Hi Wang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on linux/master v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Wang-ShaoBo/sys_personality-Add-optional-arch-hook-arch_check_personality/20200608-105348
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-randconfig-c021-20200608 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> arch/arm64/kernel/sys.c:31:5: warning: no previous prototype for 'arch_check_personality' [-Wmissing-prototypes]
31 | int arch_check_personality(unsigned int personality)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/sys.c:42:17: warning: no previous prototype for '__arm64_sys_ni_syscall' [-Wmissing-prototypes]
42 | asmlinkage long __arm64_sys_ni_syscall(const struct pt_regs *__unused)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:34:1: note: in expansion of macro '__SC_COMP'
34 | __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[0]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:34:1: note: in expansion of macro '__SC_COMP'
34 | __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:36:1: note: in expansion of macro '__SYSCALL'
36 | __SYSCALL(__NR_io_destroy, sys_io_destroy)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[1]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:36:1: note: in expansion of macro '__SYSCALL'
36 | __SYSCALL(__NR_io_destroy, sys_io_destroy)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:38:1: note: in expansion of macro '__SC_COMP'
38 | __SC_COMP(__NR_io_submit, sys_io_submit, compat_sys_io_submit)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[2]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:38:1: note: in expansion of macro '__SC_COMP'
38 | __SC_COMP(__NR_io_submit, sys_io_submit, compat_sys_io_submit)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:40:1: note: in expansion of macro '__SYSCALL'
40 | __SYSCALL(__NR_io_cancel, sys_io_cancel)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[3]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:40:1: note: in expansion of macro '__SYSCALL'
40 | __SYSCALL(__NR_io_cancel, sys_io_cancel)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:22:34: note: in expansion of macro '__SYSCALL'
22 | #define __SC_3264(_nr, _32, _64) __SYSCALL(_nr, _64)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:43:1: note: in expansion of macro '__SC_3264'
43 | __SC_3264(__NR_io_getevents, sys_io_getevents_time32, sys_io_getevents)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[4]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:22:34: note: in expansion of macro '__SYSCALL'
22 | #define __SC_3264(_nr, _32, _64) __SYSCALL(_nr, _64)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:43:1: note: in expansion of macro '__SC_3264'
43 | __SC_3264(__NR_io_getevents, sys_io_getevents_time32, sys_io_getevents)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
48 | __SYSCALL(__NR_setxattr, sys_setxattr)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[5]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
48 | __SYSCALL(__NR_setxattr, sys_setxattr)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:50:1: note: in expansion of macro '__SYSCALL'
50 | __SYSCALL(__NR_lsetxattr, sys_lsetxattr)

vim +/arch_check_personality +31 arch/arm64/kernel/sys.c

30
> 31 int arch_check_personality(unsigned int personality)
32 {
33 if (personality(personality) == PER_LINUX32 &&
34 !system_supports_32bit_el0())
35 return -EINVAL;
36
37 return 0;
38 }
39

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip