Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

From: Linus Walleij
Date: Tue Jun 09 2020 - 08:48:45 EST


On Tue, May 5, 2020 at 10:27 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > I ran into a randconfig link error with debugfs disabled:
> >
> > arm-linux-gnueabi-ld:
> > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump': msm_gpu.c:(.text+0x1cc): undefined reference to `rd_full'
> >
> > Change the helper to only look at this variable if debugfs is present.
> >
> > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> This fixes a compilation error for me on the APQ8060.
> Tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Could someone be so kind and apply this fix to the MSM DRM tree?

Yours,
Linus Walleij