Re: [PATCH] sched: correct SD_flags returned by tl->sd_flags()

[Vincent Guittot]

On Tue, 9 Jun 2020 at 17:09, Peng Liu <iwtbavbm@xxxxxxxxx> wrote:
>
> During sched domain init, we check whether non-topological SD_flags are
> returned by tl->sd_flags(), if found, fire a waning and correct the
> violation, but the code failed to correct the violation. Correct this.
>
> Fixes: 143e1e28cb40 ("sched: Rework sched_domain topology definition")
> Signed-off-by: Peng Liu <iwtbavbm@xxxxxxxxx>

Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

> ---
>  kernel/sched/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index ba81187bb7af..9079d865a935 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1328,7 +1328,7 @@ sd_init(struct sched_domain_topology_level *tl,
>                 sd_flags = (*tl->sd_flags)();
>         if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS,
>                         "wrong sd_flags in topology description\n"))
> -               sd_flags &= ~TOPOLOGY_SD_FLAGS;
> +               sd_flags &= TOPOLOGY_SD_FLAGS;
>
>         /* Apply detected topology flags */
>         sd_flags |= dflags;
> --
> 2.20.1
>