RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.

[Leo Li]

> -----Original Message-----
> From: Hui Song <hui.song_1@xxxxxxx>
> Sent: Tuesday, June 9, 2020 4:38 AM
> To: linux-devel@xxxxxxxxxxxxxxxxxx; Shawn Guo <shawnguo@xxxxxxxxxx>;
> Leo Li <leoyang.li@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark
> Rutland <mark.rutland@xxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>;
> Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; Hui Song
> <hui.song_1@xxxxxxx>
> Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
> 
> From: Song Hui <hui.song_1@xxxxxxx>
> 
> delete the interrupt IRQF_NO_THREAD flags.

I think this is the correct direction but would be better to describe a little bit on what motived this change.  Any issue encountered or latency optimization?

> 
> Signed-off-by: Song Hui <hui.song_1@xxxxxxx>
> ---
>  drivers/gpio/gpio-mpc8xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index
> 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device
> *pdev)
> 
>  	ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
>  			       mpc8xxx_gpio_irq_cascade,
> -			       IRQF_NO_THREAD | IRQF_SHARED, "gpio-
> cascade",
> +			       IRQF_SHARED, "gpio-cascade",
>  			       mpc8xxx_gc);
>  	if (ret) {
>  		dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d),
> ret = %d\n",
> --
> 2.9.5