Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

From: Sergey Senozhatsky
Date: Wed Jun 10 2020 - 06:49:13 EST


On (20/06/10 12:17), Tomasz Figa wrote:
[..]
> > Is it OK with you if I fold this patch into the original patch series and make a
> > new PR for it? I prefer to have a series merged without a bug, rather than fixing
> > it in a final patch.
>
> I believe this didn't introduce any real bug, because dma_attrs would
> end up used only for MMAP buffers anyway. Still, the current behavior
> could end up being confusing for whoever has to deal with vb2 in the
> future, so should be fixed.

This also requires user-space code that constantly use different ->memory
types and ->flags in inoctl()-s on the same queue.

-ss