Re: [PATCH v4 0/3] Add support for SQI and master-slave

[Michal Kubecek]

On Wed, Jun 10, 2020 at 10:37:41AM +0200, Oleksij Rempel wrote:
> This patch set is extending ethtool to make it more usable on automotive
> PHYs like NXP TJA11XX.
> 
> They make use of new KAPI (currently in net-next, will go probably to the
> kernel 5.8-rc1):
> - PHY master-slave role configuration and status informaton. Mostly needed
>   for 100Base-T1 PHYs due the lack of autonegatiation support.
> - Signal Quality Index to investigate cable related issues.
> 
> changes v4:
> - rebase is against current ethtool master
> - pull headers from current kernel master
> - use tabs instead of spaces in the manual
> 
> changes v3:
> - rename "Port mode" to "master-slave"
> - use [preferred|forced]-[master|slave] for information and
>   configuration
> 
> changes v2:
> - add master-slave information to the "ethtool --help" and man page
> - move KAPI update changes to the separate patch. 
> 
> Oleksij Rempel (3):
>   update UAPI header copies
>   netlink: add master/slave configuration support
>   netlink: add LINKSTATE SQI support
> 
>  ethtool.8.in                 |  19 +++++
>  ethtool.c                    |   1 +
>  netlink/desc-ethtool.c       |   4 +
>  netlink/settings.c           |  66 +++++++++++++++
>  uapi/linux/ethtool.h         |  16 +++-
>  uapi/linux/ethtool_netlink.h | 153 ++++++++++++++++++++++++++++++++++-
>  uapi/linux/genetlink.h       |   2 +
>  uapi/linux/if_link.h         |   1 +
>  uapi/linux/netlink.h         | 103 +++++++++++++++++++++++
>  uapi/linux/rtnetlink.h       |   6 ++
>  10 files changed, 369 insertions(+), 2 deletions(-)
> 
> -- 
> 2.27.0
> 

The series looks good to me, I'll wait for another day or two for other
comments and apply it there are no objections.

Michal