Re: [PATCH v2 3/5] ARM: mstar: Add infinity/mercury series dtsi

[Andreas FÃrber]

Hi,

Am 11.06.20 um 16:19 schrieb Daniel Palmer:
> On Thu, 11 Jun 2020 at 22:39, Andreas FÃrber <afaerber@xxxxxxx> wrote:
> > > diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi
> > > new file mode 100644
> > > index 000000000000..0fccc4ca52a4
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/mstar-v7.dtsi
> >
> > So this is the only file starting with mstar. Have you thought about
> > prefixing infinity/mercury, so that they're grouped together?
>
> I have been thinking about that. I didn't see any other dts in arm that had
> the vendor as a prefix though. With arm64 everything is in per vendor
> subdirectories
> to achieve the same thing.

qcom- and arm- are examples. Admittedly outliers, but for a new target 
you don't have all the historical backwards-compatibility baggage.

The downside would be if someone wanted to add newer sstar chips under 
the new name later, then they wouldn't be grouped with predecessor 
families. Right now it seems like mercury and infinity are not that 
different, so I figured it might be useful for people contributing 
patches to see that changes in one might require review of the other.

Cheers,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer
HRB 36809 (AG NÃrnberg)