Re: [PATCH v3] gpiolib: split character device into gpiolib-cdev

From: Kent Gibson
Date: Tue Jun 16 2020 - 05:40:25 EST


On Tue, Jun 16, 2020 at 10:37:32AM +0200, Linus Walleij wrote:
> On Wed, Jun 10, 2020 at 1:52 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> > Split the cdev specific functionality out of gpiolib.c and into
> > gpiolib-cdev.c. This improves the readability and maintainability of both
> > the cdev and core gpiolib code.
> >
> > Suggested-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>
> >
> > ---
> >
> > Changes in v3:
> > - updated the gpiolib-cdev.c file comment.
> > - rebased to latest gpio/devel (no changes impacted this patch)
> > - dropped the patch commentary as the points mentioned are mostly
> > resolved - there still remain a couple of commits in gpio/fixes that will
> > conflict...
>
> I rebased my GPIO tree on v5.8-rc1 and the old version of the patch did
> not apply and neither did this, could you rebase this patch so I can
> apply it? Sorry for the moving target, the merge window times are
> a bit bumpy. :/
>

No problem - I was expecting a rebase to be in that patch's future from
the beginning.

Give v4 a try.

Cheers,
Kent.