Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge

From: Nicolas Saenz Julienne
Date: Tue Jun 16 2020 - 10:09:59 EST


On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> Hi Nicolas,
>
> On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
> <nsaenzjulienne@xxxxxxx> wrote:
> > There is no distinction in DT between the PCI controller device and the
> > root bridge, whereas such distinction exists from dm's perspective. Make
> > sure the root bridge ofnode is assigned to the controller's platform
> > device node.
> >
> > This permits setups like this to work correctly:
> >
> > pcie {
> > compatible = "...";
> > ...
> > dev {
> > reg = <0 0 0 0 0>;
> > ...
> > };
> > };
> >
> > Without this the dev node is assigned to the root bridge and the
> > actual device search starts one level lower than expected.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
> > ---
> > drivers/pci/pci-uclass.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
>
> Can you update the tests to handle this case please?

I'd be glad to, but I'm not familiar with the test FW in u-booy, coud give me
some pointers on where/how to test this?

Regards,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part