Re: [PATCH v5 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller

From: Bjorn Helgaas
Date: Tue Jun 16 2020 - 18:04:56 EST


On Tue, Jun 16, 2020 at 04:55:09PM -0400, Jim Quinlan wrote:
> From: Jim Quinlan <jquinlan@xxxxxxxxxxxx>
>
> A reset controller "rescal" is shared between the AHCI driver and the PCIe
> driver for the BrcmSTB 7216 chip. The code is modified to allow this
> sharing and to deassert() properly.

Use imperative mood, e.g.,

A reset controller "rescal" is shared between the AHCI driver and
the PCIe driver for the BrcmSTB 7216 chip. Use
devm_reset_control_get_optional_shared control() to handle this
sharing.

> Signed-off-by: Jim Quinlan <jquinlan@xxxxxxxxxxxx>
>
> Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting")
> Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller
> name")

Don't wrap "Fixes:" lines so it's easier to search for them.