Re: [PATCH v2 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support

From: Takashi Iwai
Date: Wed Jun 17 2020 - 05:06:01 EST


On Wed, 17 Jun 2020 06:58:24 +0200,
Kai-Heng Feng wrote:
>
> Currently, HDA codec LED class can only used by by GPIO controlled LED.

A typo and missing verb :)

> However, there are some new systems that control LED via COEF instead of
> GPIO.
>
> In order to support those systems, create a new helper that can be
> facilitated by both COEF controlled and GPIO controlled LED, and use
> generic call_micmute_led_update() to control both case.

An exported symbol should have the proper prefix (snd_hda_gen_xxx).


thanks,

Takashi