Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

From: Michael Chan
Date: Wed Jun 17 2020 - 15:07:27 EST


On Wed, Jun 17, 2020 at 11:51 AM David Christensen
<drc@xxxxxxxxxxxxxxxxxx> wrote:
>
> The driver function tg3_io_error_detected() calls napi_disable twice,
> without an intervening napi_enable, when the number of EEH errors exceeds
> eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.
>
> Add check for pcierr_recovery which skips code already executed for the
> "Frozen" state.
>
> Signed-off-by: David Christensen <drc@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Thanks.