Re: [PATCH] drm/arm: fix unintentional integer overflow on left shift

From: Dan Carpenter
Date: Thu Jun 18 2020 - 11:22:25 EST


On Thu, Jun 18, 2020 at 04:36:51PM +0200, Garrit Franke wrote:
> Hi all, newbie here.
> Can the BIT macro be safely used on other parts of the kernel as well?
> Just using git grep "1 <<" returns a ton of results where bit shifting
> is used the old fashioned way.

Yeah. There is a checkpatch warning for it and everything. :)

But I like the way you think. Start with patches to staging though.
People don't necessarily like doing cleanups on ancient code.

regards,
dan carpenter