Re: [PATCH v2 0/6] add regmap & indirect access support

From: Tom Rix
Date: Thu Jun 18 2020 - 15:46:43 EST


This set looks good to me.

Reviewed-by : Tom Rix <trix@xxxxxxxxxx>

Tom

On 6/18/20 8:25 AM, Xu Yilun wrote:
> Updated the regmap & indirect access support for spi-altera.
>
> Patch #1, #2, #3 is already applied.
> Patch #4 is an 1:1 replacement of of readl/writel with regmap_read/write
> Patch #5 introduced a new platform_device_id to support indirect access as
> a sub device.
> Patch #6 is a minor fix.
>
> Main changes from v1:
> - Split the v1 Patch #4 to v2 Patch #4 & #5.
> - Add a new platform_device_id to support indirect access.
> - Removed the v1 Patch #5. Now we use driver name string directly.
> - Add Yilun's Signed-off-by for Patch #6
>
>
> Matthew Gerlach (1):
> spi: altera: fix size mismatch on 64 bit processors
>
> Xu Yilun (5):
> spi: altera: add 32bit data width transfer support.
> spi: altera: add SPI core parameters support via platform data.
> spi: altera: add platform data for slave information.
> spi: altera: use regmap-mmio instead of direct mmio register access
> spi: altera: support indirect access to the registers
>
> drivers/spi/Kconfig | 1 +
> drivers/spi/spi-altera.c | 177 +++++++++++++++++++++++++++++++++++++++------
> include/linux/spi/altera.h | 29 ++++++++
> 3 files changed, 183 insertions(+), 24 deletions(-)
> create mode 100644 include/linux/spi/altera.h
>