Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible

From: Sivaprakash Murugesan
Date: Fri Jun 19 2020 - 21:07:34 EST



On 6/20/2020 6:06 AM, Stephen Boyd wrote:
Quoting Sivaprakash Murugesan (2020-06-06 03:55:04)
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53
pll found on ipq6018 devices.

Signed-off-by: Sivaprakash Murugesan <sivaprak@xxxxxxxxxxxxxx>
---
[V7]
* Addressed minor review comment from Rob
.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
index 20d2638..3161fab 100644
--- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
@@ -15,6 +15,7 @@ description:
properties:
compatible:
+ const: qcom,ipq6018-a53pll
const: qcom,msm8916-a53pll
reg:
I'm getting this error when running dt binding check:

ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
in "<unicode string>", line 18, column 5
found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll")
in "<unicode string>", line 19, column 5

This error started coming after updating the dt-schema version.

Guess I need to replace const with enum to get rid of this error.

willÂaddress this.