Re: [PATCH v3] drm/amd: Fix memory leak according to error branch

From: Markus Elfring
Date: Sat Jun 20 2020 - 08:37:47 EST


> The function kobject_init_and_add alloc memory like:
> kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> ->kmalloc_slab, in err branch this memory not free. If use
> kmemleak, this path maybe catched.
> These changes are to add kobject_put in kobject_init_and_add
> failed branch, fix potential memleak.
â
> Changes since V2:
> *remove duplicate kobject_put in kfd_procfs_init.

Under which circumstances are going to improve this change description accordingly?

Would you like to add the tag âFixesâ to the commit message?

Regards,
Markus