Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

[Bjorn Andersson]

On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:

> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> 
> Build error:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:
>   In function ‘q6v5_mpss_init_image’:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
>   error: implicit declaration of function ‘kfree’;
>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
>    772 |   kfree(metadata);
>        |   ^~~~~
>        |   vfree
> 
> Signed-off-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>

Thanks for the patch Naresh, it looks correct but I've not seen this
build error myself. Could you please let me know what you built to get
this and if you have any suggestion on what caused it? (So we can add a
Fixes: tag etc)

Regards,
Bjorn

> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
>  #include <linux/reset.h>
>  #include <linux/soc/qcom/mdt_loader.h>
>  #include <linux/iopoll.h>
> +#include <linux/slab.h>
>  
>  #include "remoteproc_internal.h"
>  #include "qcom_common.h"
> -- 
> 2.17.1
>