Re: [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning when hibernating

From: Sasha Levin
Date: Sun Jun 21 2020 - 19:46:29 EST


On Thu, Jun 18, 2020 at 10:56:01AM +0100, Qais Yousef wrote:
Hi Sasha/Alan

On 06/17/20 21:05, Sasha Levin wrote:

[...]

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 7addfc2cbadc..4a8456f12a73 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -299,6 +299,11 @@ static int ohci_platform_resume(struct device *dev)
}

ohci_resume(hcd, false);
+
+ pm_runtime_disable(dev);
+ pm_runtime_set_active(dev);
+ pm_runtime_enable(dev);
+

I am not sure what's the protocol here, but the series was fixing similar
problems to this driver but I didn't myself directly observe a warning because
of that.

https://lore.kernel.org/lkml/20200518154931.6144-2-qais.yousef@xxxxxxx/
https://lore.kernel.org/lkml/20200518154931.6144-3-qais.yousef@xxxxxxx/

So just pointing it out in case they're worth backporting to stable too.

I'll grab them too, thanks!

--
Thanks,
Sasha