Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand

From: Oleg Nesterov
Date: Mon Jun 22 2020 - 02:25:41 EST


On 06/21, Alexander Kapshuk wrote:
>
> Export symbol __lock_task_sighand, so it is accessible from code compiled
> as modules.
> This fixes the following modpost error:
> ERROR: modpost: "__lock_task_sighand" [net/9p/9pnet.ko] undefined!
>
> Where __lock_task_sighand is called via lock_task_sighand in net/9p/client.c
> See https://lore.kernel.org/lkml/20200620201456.14304-1-alexander.kapshuk@xxxxxxxxx/.

Why?

current->sighand is stable and can't go away. Unless "current" is exiting and
has already passed exit_notify(). So I don't think net/9p needs this helper.

However, the games with TIF_SIGPENDING doesn't look right in any case.

Oleg.