Re: [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver

From: Lee Jones
Date: Mon Jun 22 2020 - 07:14:25 EST


On Mon, 22 Jun 2020, Johnson CH Chen (éæå) wrote:

> Dallas/Maxim DS1374 is a counter designed to continuously count
> time in seconds. It provides an I2C interface to the host to
> access RTC clock or Alarm/Watchdog timer.
>
> Add MFD Core driver, supporting the I2C communication to RTC and
> Watchdog devices.
>
> Signed-off-by: Johnson Chen <johnsonch.chen@xxxxxxxx>
> ---
> drivers/mfd/Kconfig | 11 +++++
> drivers/mfd/Makefile | 2 +
> drivers/mfd/ds1374.c | 101 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 114 insertions(+)
> create mode 100644 drivers/mfd/ds1374.c

Not sure I see the point of this driver.

How/where is the device part registered?

Is it DT only? If not, what else?

Also where are the bindings?

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 687e9c848053w.d16031f4b487 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1980,6 +1980,17 @@ config MFD_STM32_LPTIMER
> To compile this driver as a module, choose M here: the
> module will be called stm32-lptimer.
>
> +config MFD_DS1374
> + tristate "Support for Dallas/Maxim DS1374"
> + depends on I2C
> + select MFD_CORE
> + help
> + Say yes here to add support for Dallas/Maxim DS1374 Semiconductor.
> + This driver provides RTC and watchdog.
> +
> + This driver can also be built as a module. If so, module will be
> + called ds1374.
> +
> config MFD_STM32_TIMERS
> tristate "Support for STM32 Timers"
> depends on (ARCH_STM32 && OF) || COMPILE_TEST

--
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog