Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[] cleanup

From: David Miller
Date: Mon Jun 22 2020 - 19:34:10 EST


From: Alexander Lobakin <alobakin@xxxxx>
Date: Sun, 21 Jun 2020 09:55:50 +0000

> This little series adds the last forgotten feature string for
> NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses
> in future.
>
> Patches 2-3 seem more like net-next candidates rather than net-fixes,
> but for me it seems a bit more suitable to pull it during "quiet" RC
> windows, so any new related code could start from this base.
>
> I was thinking about some kind of static assertion to have an early
> prevention mechanism for this, but the existing of 2 intended holes
> (former NO_CSUM and UFO) makes this problematic, at least at first
> sight.
>
> v2:
> - fix the "Fixes:" tag in the first patch;
> - no functional changes.

Please do not mix bug fixes (missing netdev feature strings, etc.) with
cleanups (indentation changes).

Thank you.