Re: [PATCH v2] mm/page_alloc: fix documentation error and remove magic numbers

From: Matthew Wilcox
Date: Wed Jun 24 2020 - 13:01:52 EST


On Wed, Jun 24, 2020 at 12:49:43PM -0400, Joel Savitz wrote:
> When I increased the upper bound of the min_free_kbytes value in
> ee8eb9a5fe863, I forgot to tweak the above comment to reflect
> the new value. This patch fixes that mistake.
>
> In addition, this patch replaces the magic number bounds with symbolic
> constants to clarify the logic.
>
> changes from v1:
> - declare constants via enum instead of separate integers
>
> Suggested-by: John Hubbard <jhubbard@xxxxxxxxxx>
> Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Joel Savitz <jsavitz@xxxxxxxxxx>

NAK. Just fix the documentation. It's bad form to combine two completely
different things in one patch anyway.