Re: [PATCH] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

From: Marcelo Ricardo Leitner
Date: Wed Jun 24 2020 - 16:31:31 EST


On Tue, Jun 23, 2020 at 11:04:17AM -0500, minyard@xxxxxxx wrote:
> From: Corey Minyard <cminyard@xxxxxxxxxx>
>
> If a socket was set ipv6only, it would still send IPv4 addresses in the
> init and init ack packets. So don't add IPv4 addresses to ipv6only
> sockets.
>
> Based on a patch by Xin Long <lucien.xin@xxxxxxxxx>
>
> Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>
> ---
> I have tested this and it seem to fix the issue. However, I'm wondering
> if it might be better to fix it where the addresses are put into the
> association as opposed to where they are put into the message.

Yes, it is. It even highlights why this issue was there in the first
place. Sending a patch right after this email.

Marcelo