Re: Null-ptr-deref due to "vfs, fsinfo: Add an RCU safe per-ns mount list"

From: Stephen Rothwell
Date: Wed Jun 24 2020 - 21:25:54 EST


Hi all,

On Wed, 24 Jun 2020 11:57:07 -0400 Qian Cai <cai@xxxxxx> wrote:
>
> On Wed, May 13, 2020 at 12:29:52AM +0100, David Howells wrote:
> > Qian Cai <cai@xxxxxx> wrote:
> >
> > > Reverted the linux-next commit ee8ad8190cb1 (âvfs, fsinfo: Add an RCU safe per-ns mount listâ) fixed the null-ptr-deref.
> >
> > Okay, I'm dropping this commit for now.
>
> What's the point of re-adding this buggy patch to linux-next again since
> 0621 without fixing the previous reported issue at all? Reverting the
> commit will still fix the crash below immediately, i.e.,
>
> dbc87e74d022 ("vfs, fsinfo: Add an RCU safe per-ns mount list")

I have added a revert of that commit to linux-next today.

--
Cheers,
Stephen Rothwell

Attachment: pgpVHaDq37aYw.pgp
Description: OpenPGP digital signature