Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

From: Neil Armstrong
Date: Fri Jun 26 2020 - 07:55:25 EST


Hi,

On 19/06/2020 00:09, Doug Anderson wrote:
> Hi,
>
> On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P <harigovi@xxxxxxxxxxxxxx> wrote:
>>
>> ti-sn65dsi86 bridge is enumerated as a runtime device. When
>> suspend is triggered, PM core adds a refcount on all the
>> devices and calls device suspend, since usage count is
>> already incremented, runtime suspend will not be called
>> and it kept the bridge regulators and gpios ON which resulted
>> in platform not entering into XO shutdown.
>>
>> Add changes to force suspend on the runtime device during pm sleep.
>>
>> Signed-off-by: Harigovindan P <harigovi@xxxxxxxxxxxxxx>
>> ---
>>
>> Changes in v2:
>> - Include bridge name in the commit message and
>> remove dependent patchwork link from the commit
>> text as bridge is independent of OEM(Stephen Boyd)
>>
>> Changes in v3:
>> - Updating changelog to explain the need for patch
>>
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I think this patch is good to go now (has both Stephen's and my
> reviews). I noticed that Neil landed my other patches to this driver
> recently (thanks!) and wondered why he didn't land this one. Then, I
> realized that you didn't send it to him or the other bridge
> maintainer. :( Have you tried running get_maintainer?
>
> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/bridge/ti-sn65dsi86.c
> Andrzej Hajda <a.hajda@xxxxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
> Neil Armstrong <narmstrong@xxxxxxxxxxxx> (maintainer:DRM DRIVERS FOR
> BRIDGE CHIPS)
> Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> (reviewer:DRM
> DRIVERS FOR BRIDGE CHIPS)
> Jonas Karlman <jonas@xxxxxxxxx> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
> Jernej Skrabec <jernej.skrabec@xxxxxxxx> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
> David Airlie <airlied@xxxxxxxx> (maintainer:DRM DRIVERS)
> Daniel Vetter <daniel@xxxxxxxx> (maintainer:DRM DRIVERS)
> dri-devel@xxxxxxxxxxxxxxxxxxxxx (open list:DRM DRIVERS)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> In any case, unless someone has extra feedback on this patch I think
> it's ready to land.
>
> Neil: If you're willing to land this patch too, can you let
> Harigovindan know if it needs to be re-sent with you in the "To:" list
> or if you can find it on the dri-devel list?

Sorry missed this one,

Applying to drm-misc-next

Neil

>
> Thanks!
>
> -Doug
>