Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

From: Andy Shevchenko
Date: Thu Jul 02 2020 - 05:31:18 EST


On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@xxxxxxxxxxxxx> wrote:
>
> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
>
> brightness_enable is already checked at the beginning,

> Always print notice when enabled brightness control.

Why?

...

> + pr_notice("thinkpad_acpi native brightness control enabled\n");

'notice' level is quite high, why do we spam users with this?

--
With Best Regards,
Andy Shevchenko