Re: [PATCH v2 0/4] Remove 32-bit Xen PV guest support

From: Brian Gerst
Date: Thu Jul 02 2020 - 10:49:09 EST


On Wed, Jul 1, 2020 at 7:07 AM Juergen Gross <jgross@xxxxxxxx> wrote:
>
> The long term plan has been to replace Xen PV guests by PVH. The first
> victim of that plan are now 32-bit PV guests, as those are used only
> rather seldom these days. Xen on x86 requires 64-bit support and with
> Grub2 now supporting PVH officially since version 2.04 there is no
> need to keep 32-bit PV guest support alive in the Linux kernel.
> Additionally Meltdown mitigation is not available in the kernel running
> as 32-bit PV guest, so dropping this mode makes sense from security
> point of view, too.

One thing that you missed is removing VDSO_NOTE_NONEGSEG_BIT from
vdso32/note.S. With that removed there is no difference from the
64-bit version.

Otherwise this series looks good to me.
--
Brian Gerst