Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter

From: Joe Perches
Date: Fri Jul 03 2020 - 05:43:57 EST


On Fri, 2020-07-03 at 11:35 +0200, Miguel Ojeda wrote:
> On Fri, Jul 3, 2020 at 9:44 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > And I'd generally not bother with 80 column rewrapping
>
> Thanks for the quick answer Joe -- here I was referring to the cases
> where one needs to move all the `=`s to the right like:
>
> static const struct file_operations memtype_fops = {
> .open = memtype_seq_open,
> - .read = seq_read,
> + .read_iter = seq_read_iter,
> .llseek = seq_lseek,
> .release = seq_release,
> };
>
> (I don't think there is any/many cases of 80-column rewrapping here).

OK.

I'm not much bothered much by alignments like that and
I don't see a good way to automate such conversions as
some might, as here, use spaces to align to = and most
would use tabs.