Re: [PATCH ghak124 v3fix] audit: add gfp parameter to audit_log_nfcfg

From: Richard Guy Briggs
Date: Fri Jul 03 2020 - 10:19:23 EST


On 2020-07-03 09:41, Paul Moore wrote:
> On Fri, Jul 3, 2020 at 8:41 AM Jones Desougi
> <jones.desougi+netfilter@xxxxxxxxx> wrote:
> >
> > Doesn't seem entirely consistent now either though. Two cases below.
>
> Yes, you're right, that patch was incorrect; thanks for catching that.
> I just posted a fix (lore link below) that fixes the two problems you
> pointed out as well as converts a call in a RCU protected section to
> an ATOMIC.

Thanks Paul. I was just about to switch branches and fix these. :-)
I really need to upgrade this devel machine so I can use git 2.x
worktrees...

I checked all of these (I thought) thoroughly before I started changing
code and obviously didn't after. :-/

> https://lore.kernel.org/linux-audit/159378341669.5956.13490174029711421419.stgit@sifl
>
> paul moore

- RGB

--
Richard Guy Briggs <rgb@xxxxxxxxxx>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635