Re: [PATCH] exfat: implement "quiet" option for setattr

From: Ju Hyung Park
Date: Mon Jul 06 2020 - 04:22:58 EST


Hi Namjae.

Looks like I ported this incorrectly from the previous sdFAT base.

I'll fix, test again and send v2.

Thanks.

On Thu, Jul 2, 2020 at 2:16 PM Namjae Jeon <namjae.jeon@xxxxxxxxxxx> wrote:
>
> >
> > if (((attr->ia_valid & ATTR_UID) &&
> > !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6 +325,12 @@ int
> > exfat_setattr(struct dentry *dentry, struct iattr *attr)
> > goto out;
> You should remove goto statement and curly braces here to reach if error condition.
> > }
> >
> > + if (error) {
> > + if (sbi->options.quiet)
> > + error = 0;
> > + goto out;
> > + }
>