Re: [PATCH v10 0/9] firmware: add request_partial_firmware_into_buf

[Scott Branden]

Hi Florian,

On 2020-07-07 9:38 p.m., Florian Fainelli wrote:
> On 7/6/2020 4:23 PM, Scott Branden wrote:
> > This patch series adds partial read support via a new call
> > request_partial_firmware_into_buf.
> > Such support is needed when the whole file is not needed and/or
> > only a smaller portion of the file will fit into allocated memory
> > at any one time.
> > In order to accept the enhanced API it has been requested that kernel
> > selftests and upstreamed driver utilize the API enhancement and so
> > are included in this patch series.
> >
> > Also in this patch series is the addition of a new Broadcom VK driver
> > utilizing the new request_firmware_into_buf enhanced API.
> >
> > Further comment followed to add IMA support of the partial reads
> > originating from request_firmware_into_buf calls.  And another request
> > to move existing kernel_read_file* functions to its own include file.
> Do you have any way to separate the VK drivers submission from the
> request_partial_firmware_into_buf() work that you are doing? It looks
> like it is going to require quite a few iterations of this patch set for
> the firmware/fs/IMA part to be ironed out, so if you could get your
> driver separated out, it might help you achieve partial success here.
Originally I did not submit the driver.
But Greg K-H rejected the pread support unless there was an actual user 
in the kernel.
Hence the need to submit this all in the patch series.