Re: [PATCH v5 13/13] arm64: dts: freescale: sl28: enable fan support

[Michael Walle]

Hi Linus,

Am 2020-07-08 09:39, schrieb Linus Walleij:
> just a drive-by-comment:
>
> On Mon, Jul 6, 2020 at 7:57 PM Michael Walle <michael@xxxxxxxx> wrote:
>
> > Add a pwm-fan mapped to the PWM channel 0 which is connected to the
> > fan connector of the carrier.
> >
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
>
> If you have a cooling device like this, do you also have a temperature
> sensor? In that case it makes sense to add a thermal zone and a
> policy, such as I did for a device in
> 6e97f0aaca4ca778905dd1dc667cbf379f4cae15

Yep, the CPU and DDR controller have temperatur sensors and there are
already thermal zones for them. We have the fan linked to the policies
in our vendor DTS overlay. For now I didn't want to include that here,
mainly because there are no labels in the fsl-ls1028a.dtsi for the
thermal zone/cooling maps/trips. But this is still on my TODO, when
this series finally make it into the kernel ;)

-michael