Re: [PATCH 11/30] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters

From: Lee Jones
Date: Wed Jul 08 2020 - 08:24:05 EST


On Wed, 08 Jul 2020, Johannes Thumshirn wrote:

> On 08/07/2020 14:04, Lee Jones wrote:
> > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata,
> > * fc_rport_logo_resp() - Handler for logout (LOGO) responses
> > * @sp: The sequence the LOGO was on
> > * @fp: The LOGO response frame
> > - * @lport_arg: The local port
> > + * @rport_arg: The local port
> > */
> > static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp,
> > void *rdata_arg)
>
> That doesn't look correct, s/rport_arg/rdata_arg/ and an rport is a remote port not a local port.

That's interesting. Looks like I fixed this later in the set.

--
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog