Re: [PATCH v3 3/8] KVM: X86: Introduce kvm_check_cpuid()

[Paolo Bonzini]

On 08/07/20 14:28, Xiaoyao Li wrote:
>> @@ -202,12 +208,16 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu,
>> ÂÂÂÂÂÂÂÂÂ vcpu->arch.cpuid_entries[i].padding[2] = 0;
>> ÂÂÂÂÂ }
>> ÂÂÂÂÂ vcpu->arch.cpuid_nent = cpuid->nent;
>> +ÂÂÂ r = kvm_check_cpuid(vcpu);
>> +ÂÂÂ if (r) {
>> +ÂÂÂÂÂÂÂ vcpu->arch.cpuid_nent = 0;
> 
> Paolo,
> 
> here lack a kvfree(cpuid_entries);
> Can you help fix it?
> 
> Apologize for it.

Actually I hadn't queued this patch; my mistake.  You can fix it and resend.

Paolo