Re: [PATCH 6/6] mmc: remove the call to check_disk_change

From: Ulf Hansson
Date: Wed Jul 08 2020 - 10:18:09 EST


On Wed, 8 Jul 2020 at 14:41, Christoph Hellwig <hch@xxxxxx> wrote:
>
> The mmc driver doesn't support event notifications, which means
> that check_disk_change is a no-op.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I can queue this via my mmc tree, but perhaps you have plans for some
additional cleanups on top? In such a case, it may be better that this
goes through Jens' tree?

Kind regards
Uffe

> ---
> drivers/mmc/core/block.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 4791c82f8f7c78..fa313b63413547 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -312,10 +312,7 @@ static int mmc_blk_open(struct block_device *bdev, fmode_t mode)
>
> mutex_lock(&block_mutex);
> if (md) {
> - if (md->usage == 2)
> - check_disk_change(bdev);
> ret = 0;
> -
> if ((mode & FMODE_WRITE) && md->read_only) {
> mmc_blk_put(md);
> ret = -EROFS;
> --
> 2.26.2
>