Re: [PATCH][next] netfilter: nf_tables: Use fallthrough pseudo-keyword

From: Gustavo A. R. Silva
Date: Wed Jul 08 2020 - 14:25:09 EST


On Wed, Jul 08, 2020 at 06:09:31PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Jul 07, 2020 at 02:47:17PM -0500, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
>
> I suggest:
>
> netfilter: Use fallthrough pseudo-keyword
>
> instead, since this is also updating iptables and ipset codebase.
>

Yep; I noticed that, but forgot to change the subject before submitting
the patch.

I will address the rest of the comments and send v2, shortly.

Thanks
--
Gustavo