Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold

From: Chanwoo Choi
Date: Wed Jul 08 2020 - 23:56:54 EST


Hi Lukasz,

On 7/9/20 12:34 AM, Lukasz Luba wrote:
> In order to react faster and make better decisions under some workloads,
> benchmarking the memory subsystem behavior, adjust the polling interval
> and upthreshold value used by the simple_ondemand governor.
>
> Reported-by: Willy Wolff <willy.mh.wolff.ml@xxxxxxxxx>
> Signed-off-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 93e9c2429c0d..e03ee35f0ab5 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
> * Setup default thresholds for the devfreq governor.
> * The values are chosen based on experiments.
> */
> - dmc->gov_data.upthreshold = 30;
> + dmc->gov_data.upthreshold = 10;
> dmc->gov_data.downdifferential = 5;
>
> - exynos5_dmc_df_profile.polling_ms = 500;
> + exynos5_dmc_df_profile.polling_ms = 100;
> }
>
>
>

Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

--
Best Regards,
Chanwoo Choi
Samsung Electronics